Present watched recommendation seeds and request history truthfully

wolfskin-design/src/test/java/org/justinvisser/wolfskin/design/DiscoverLaneProjectionTest.kt

@@ -8,7 +8,7 @@ import org.junit.Test
 class DiscoverLaneProjectionTest {
     @Test fun discardedSeedGroupRemainsAvailableInCatalogue() {
         val titles = (1L..6L).map { DiscoverTitle(it, "movie", "Film $it") }
-        val snapshot = DiscoverSnapshot(picks = titles, seeds = listOf(DiscoverSeed("Seed", titles.subList(3, 5))),
+        val snapshot = DiscoverSnapshot(picks = titles, seeds = listOf(DiscoverSeed("movie:10", "Seed", titles.subList(3, 5), watched = true, added = false)),
             lanes = listOf(DiscoverLane("trending", "Trending", titles)), status = DiscoverStatus.Ready)
         val rows = projectDiscoverLanes(snapshot, emptyList(), "all", emptyMap())
         assertEquals(listOf("pk-movie", "trending"), rows.map { it.id })
@@ -30,4 +30,25 @@ class DiscoverLaneProjectionTest {
         val filtered = projectDiscoverLanes(snapshot, emptyList(), "tv", mapOf(hidden.key to hidden))
         assertEquals(listOf(listOf(series)), filtered.map { it.titles })
     }
+
+    @Test fun addedOnlySeedsKeepTheirPicksWithoutClaimingTheyWereWatched() {
+        val titles = (1L..9L).map { DiscoverTitle(it, "movie", "Film $it") }
+        val snapshot = DiscoverSnapshot(picks = titles, seeds = listOf(
+            DiscoverSeed("movie:10", "Added seed", titles, watched = false, added = true)), status = DiscoverStatus.Ready)
+        val lanes = projectDiscoverLanes(snapshot, emptyList(), "all", emptyMap())
+        assertEquals(listOf("Movies for you"), lanes.map { it.title })
+        assertEquals(titles, lanes.single().fullTitles)
+    }
+
+    @Test fun watchedLanesKeepWireOrderAndStableIdentityWhenTitlesCollide() {
+        val titles = (1L..24L).map { DiscoverTitle(it, "movie", "Film $it") }
+        val snapshot = DiscoverSnapshot(picks = titles, seeds = listOf(
+            DiscoverSeed("movie:50", "Added seed", titles.take(8), watched = false, added = true),
+            DiscoverSeed("tv:70", "Same title", titles.subList(8, 16), watched = true, added = true),
+            DiscoverSeed("movie:70", "Same title", titles.subList(16, 24), watched = true, added = false)),
+            status = DiscoverStatus.Ready)
+        val lanes = projectDiscoverLanes(snapshot, emptyList(), "all", emptyMap())
+        assertEquals(listOf("pk-movie", "pk-w-tv:70", "pk-w-movie:70"), lanes.map { it.id })
+        assertEquals(listOf(titles.subList(8, 16), titles.subList(16, 24)), lanes.drop(1).map { it.titles })
+    }
 }

wolfskin-design/src/test/java/org/justinvisser/wolfskin/design/RequestsKeysTest.kt

@@ -53,7 +53,6 @@ class RequestsKeysTest {
         assertEquals(path.getInt("presses"), presses.length())
         for (index in 0 until presses.length()) send(keys.getValue(presses.getString(index)))
         rule.onNodeWithTag("coming-in").assertExists()
-        rule.onNodeWithText("Requests · 5 open").assertExists()
         assertEquals("settings", state.route)
         assertEquals("x5", state.requests.focusedId)
         assertFalse(state.navFocused)
@@ -144,7 +143,5 @@ class RequestsKeysTest {
         val viewer = fixturePeople().single { it.key == "shared" }
         assertEquals("Shared", shared.actor(viewer))
         assertEquals("Justin", shared.recipient(viewer))
-        assertEquals(5, snapshot.openCount)
-        assertEquals(listOf(0, 1, 1, 2, 3, 4), snapshot.ordered.map { it.stage.rank })
     }
 }

wolfskin-design/src/test/java/org/justinvisser/wolfskin/design/ShellCaptureTest.kt

@@ -38,12 +38,12 @@ class ShellCaptureTest {
         rule.activity.window.decorView.systemUiVisibility = View.SYSTEM_UI_FLAG_FULLSCREEN or View.SYSTEM_UI_FLAG_HIDE_NAVIGATION or View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY
     }
 
-    private fun capture(name: String, openRequests: Int? = null, configure: (ShellState) -> Unit = {}) {
+    private fun capture(name: String, requestCount: Int? = null, configure: (ShellState) -> Unit = {}) {
         val state = ShellState(fixturePeople(), "justin")
         configure(state)
         rule.setContent {
             WolfskinTheme {
-                ShellSurface(state, Modifier.requiredSize(WolfskinTokens.Shell.stageWidth, WolfskinTokens.Shell.stageHeight), settingsOpenRequests = openRequests)
+                ShellSurface(state, Modifier.requiredSize(WolfskinTokens.Shell.stageWidth, WolfskinTokens.Shell.stageHeight), settingsRequestCount = requestCount)
             }
         }
         rule.mainClock.advanceTimeBy(1000)
@@ -67,7 +67,7 @@ class ShellCaptureTest {
     @Test fun st011_rememberedNav() = capture("st-011") { it.pickerVisible = false; it.navFocused = true; it.view.row = 4; it.view.cards["row-4"] = 2 }
     @Test fun st014_discoverNav() = capture("st-014") { it.pickerVisible = false; it.navFocused = true; it.navIndex = 1 }
     @Test fun st091_settings() = capture("st-091") { it.pickerVisible = false; it.enterDestination("settings") }
-    @Test fun st092_requestsCountFixture() = capture("st-092", openRequests = 5) { it.pickerVisible = false; it.enterDestination("settings") }
+    @Test fun st092_requestsCountFixture() = capture("st-092", requestCount = 5) { it.pickerVisible = false; it.enterDestination("settings") }
     @Test fun st093_profileFocus() = capture("st-093") { it.pickerVisible = false; it.enterDestination("settings"); it.settingsRow = 4 }
 }