justinzeus/wolfskin
1
0
Fork 0
Code Issues 2 Pull requests Releases 3 Packages Activity

Focus the active profile in the Select User list #15

Merged
justinzeus merged 1 commit from fm/wolfskin-7-profile-focus into main 2026-10-22 15:11:46 +02:00
Conversation 0 Commits 1 Files changed 2 +100 -7
justinzeus commented 2026-10-22 14:55:29 +02:00
Owner
Copy link

Focuses the active profile in the Select User row. Before this change the row always focused the first card, so a user who had signed in as a later profile had to scroll back to find their own card. The row now scrolls to and focuses the current profile.

What is in this PR:

  • Upstream commit f816ef03 ("Focus the active profile in the user selector", author justinzeus), cherry-picked unchanged onto v1.0.9 as 344aa999. It touches ui/setup/UserList.kt and adds UserListFocusTest.kt.
  • Nothing beyond that patch.

Conflicts: none. The cherry-pick applied cleanly to v1.0.9, so there were no resolutions to list.

Upstream: this is damontecres/Wholphin#2003 (https://github.com/damontecres/Wholphin/pull/2003), which stays open upstream. When upstream merges it and ships a tag, this Wolfskin copy is dropped at the next tag merge.

Verification (Docker referee on head 344aa9990d8248bece237feaf9bb60a9f087dc54, Gradle runs serialized with flock /tmp/wolfskin-gradle.lock):

  • make test: BUILD SUCCESSFUL. UserListFocusTest: 4 tests, 0 failures, 0 errors.
  • make apk-debug: BUILD SUCCESSFUL, debug APKs produced (Wholphin-default-debug-1.0.9-6-g344aa999-53-*.apk).

Closes justinzeus/wolfskin#7

Focuses the active profile in the Select User row. Before this change the row always focused the first card, so a user who had signed in as a later profile had to scroll back to find their own card. The row now scrolls to and focuses the current profile. What is in this PR: - Upstream commit `f816ef03` ("Focus the active profile in the user selector", author justinzeus), cherry-picked unchanged onto `v1.0.9` as `344aa999`. It touches `ui/setup/UserList.kt` and adds `UserListFocusTest.kt`. - Nothing beyond that patch. Conflicts: none. The cherry-pick applied cleanly to `v1.0.9`, so there were no resolutions to list. Upstream: this is damontecres/Wholphin#2003 (https://github.com/damontecres/Wholphin/pull/2003), which stays open upstream. When upstream merges it and ships a tag, this Wolfskin copy is dropped at the next tag merge. Verification (Docker referee on head `344aa9990d8248bece237feaf9bb60a9f087dc54`, Gradle runs serialized with `flock /tmp/wolfskin-gradle.lock`): - `make test`: BUILD SUCCESSFUL. `UserListFocusTest`: 4 tests, 0 failures, 0 errors. - `make apk-debug`: BUILD SUCCESSFUL, debug APKs produced (`Wholphin-default-debug-1.0.9-6-g344aa999-53-*.apk`). Closes justinzeus/wolfskin#7
justinzeus added 1 commit 2026-10-22 14:55:29 +02:00
Focus the active profile in the user selector
All checks were successful
review/firstmate Diff byte-identical to Justin's upstream commit f816ef03 (Wholphin#2003); worker ran make test + apk-debug green
344aa9990d
justinzeus merged commit df8614bf8b into main 2026-10-22 15:11:46 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
exploring

Idea with a proof gate; not scheduled until the gate passes

No labels
exploring
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: justinzeus/wolfskin#15
No description provided.
Delete branch "fm/wolfskin-7-profile-focus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?