## Description
Fixes some devices activating the OS screensaver during playback when
the in-app dim was enabled.
I was not able to reproduce this on Shield 2017/2019, but could easily
on a Fire TV Stick. #1834 added the dim feature and, when enabled, would
not pass the keep screen on flag to the OS during playback. It seems
maybe regular Android TV's screensaver also listened to active media
session to prevent starting but maybe Fire TV OS doesn't. I'm not 100%
sure. This PR changes the logic slightly so that the keep screen on flag
is always set during playback.
### Related issues
Fixes#1894
Related to dim feature from
https://github.com/damontecres/Wholphin/pull/1834
### Testing
Emulator, shield 2019, & fire tv stick 4k
## Screenshots
N/A
## AI or LLM usage
None
## Description
Collection of minor bug fixes for `v1.0.7`
- Fixes a possible race condition crash when navigating to the search
page
- Uses friendlier error message when login fails due to parental
restrictions (based on
[`jellyfin-web`](https://github.com/jellyfin/jellyfin-web/blob/v10.11.11/src/controllers/session/login/index.js#L38-L41))
- Don't re-sort search results by name, just by relevance scoring
- Consume the key event when dim is active (ie if the screen is dimmed,
pressing a key will un-dim and not perform another action)
### Related issues
Fixes#1922Fixes#1951
Related to #1848 (search sorting)
### Testing
Emulator & nvidia shield
## Screenshots
N/A
## AI or LLM usage
None
<!-- By submitting this pull request, you acknowledge that you have read
the [contributing
guide](https://github.com/damontecres/Wholphin/blob/main/CONTRIBUTING.md,
including the AI/LLM policy, and [developer's
guide](https://github.com/damontecres/Wholphin/blob/main/DEVELOPMENT.md)
-->
## Description
Person pages that get a filmography from Seerr had three problems, all
in the same place.
The release date was taken from `firstAirDate` alone — the field TMDB
fills for series — so
movie cards showed no year at all. The library person page capped the
row at 25 cast + 25 crew while
`DiscoverPersonPage` had no cap, because each screen carried its own
copy of the same logic.
And `cast + crew` left the row in no order a viewer can read, with a
title appearing twice when
a person is both cast and crew on it.
This PR:
* maps credit dates as `releaseDate ?: firstAirDate` — the expression
the search result mapping
already uses;
* moves the credits logic into a single `SeerrService.personCredits()`
used by both screens, so
they cannot drift apart again;
* drops the 25 + 25 cap, de-duplicates by TMDB id and sorts by release
date descending, with
undated entries last.
Rows on movie and series pages are untouched: only the
`BaseItemKind.PERSON` branch of
`similar()` changed.
Two things worth your opinion:
* Without the cap, the row for a person with a long filmography is long
— 135 cards for Cameron
Diaz, for example. If you would rather keep a cap, the row could keep
the newest 25 and gain a
`ViewMoreCard` opening the full grid — `Destination.DiscoveredItem` with
a `PERSON` item
already routes to `DiscoverPersonPage`. I am happy to add that in a
second commit.
* The sort is fixed to release date descending. It now lives in one
function, so a different key
or a user-facing choice would be cheap to add later.
### Related issues
Fixes#1873
### Testing
CI in my fork ran the repository's own PR workflow on this branch:
`pre-commit` (ktlint) and
`assembleDefaultDebug` with `testDefaultDebugUnitTest` are both green.
I then installed a debug build of the same code on an NVIDIA Shield TV
Pro 2019 (Android 11),
against Jellyfin 10.11.11 with Jellyseerr, and opened Cameron Diaz from
the cast row of
*Charlie's Angels* before and after the change:
* movie cards show a year now; before, the only two cards in the row
with a year were the two
TV entries;
* the row is ordered by release date descending, movies and series
interleaved, instead of the
API order of all cast followed by all crew;
* the row is no longer cut at 25 + 25 — it now runs back to her 1952
credit, and the entries
TMDB has no date for sit at the very end of the row.
Not tested on any other device; nothing in the change is device
specific.
## Screenshots
Person page of Cameron Diaz, reached from the cast row of *Charlie's
Angels*. The library rows
above the Discover row are the same in every shot and are useful as a
reference: they always had
their years.
Before, start of the Discover row — no year under any card:
<img width="1920" height="1080" alt="pr1873-1-before-start"
src="https://github.com/user-attachments/assets/585d0670-ae39-4214-9004-0c92262991da"
/>
Before, end of the Discover row — the row stops here, and the only two
years in it belong to the
two TV entries:
<img width="1920" height="1080" alt="pr1873-2-before-end"
src="https://github.com/user-attachments/assets/85c58575-2ad0-4369-a103-60f04c8d2350"
/>
After, start of the row — years on the movie cards, ordered by date
descending:
<img width="1920" height="1080" alt="pr1873-3-after-start"
src="https://github.com/user-attachments/assets/804745c5-e1a6-4fe4-93bd-dc6c97a7a876"
/>
After, end of the row — the list now reaches 1952, with the undated
entries last:
<img width="1920" height="1080" alt="pr1873-4-after-end"
src="https://github.com/user-attachments/assets/2c32389c-ec0b-4df5-b9d1-f564ef10d8b3"
/>
## AI or LLM usage
The code was written with Claude Opus 5 (Claude Code): the two mapping
lines, the extracted
`personCredits()` function and the two call sites. I reviewed every line
and can explain it.
This description was written by me in Russian and translated into
English with the same
assistant.
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Damontecres <damontecres@gmail.com>
## Description
Adds support to remove items from a playlist and move items within a
playlist
The remove option is in the context menu. Moving has buttons on the
right side. The buttons are available if the user has edit permissions
and the playlist is sorted by "Default" (the playlist order). Remove
from playlist option is available if the user has edit permissions.
Also, thumb images are now preferred instead of primary/poster images
since the layout is much wider than tall.
### Related issues
Closes#1881
### Testing
Emulator with both a user with & without permissions to edit
## Screenshots
### With move buttons
<img width="1280" height="720" alt="playlist_buttons Large"
src="https://github.com/user-attachments/assets/ce7880c3-b823-4b69-9ad4-cfc9e7ee5fd5"
/>
### Without move buttons
<img width="1280" height="720" alt="playlist_no_buttons Large"
src="https://github.com/user-attachments/assets/f2027052-4628-4d44-8257-6c2a5e8c3af4"
/>
## AI or LLM usage
None
## Description
Reverts/fixes parts of #1404 for the playback UI. Generally the playback
UI always uses left-to-right for seek bar & media controls even on RTL.
Other buttons or texts will be RTL.
### Related issues
Fixes#1397
### Testing
Emulator w/ forced RTL English
## Screenshots
See
https://github.com/damontecres/Wholphin/issues/1397#issuecomment-5553711593
## AI or LLM usage
None
## Description
Fixes cases where the server has duplicate season IDs causing the season
index search to fail and default to the first season in the list.
### Related issues
Fixes#1837
### Testing
Emulator & unit tests
## Screenshots
N/A
## AI or LLM usage
None
## Description
Consolidates sending reports/logs to the server into
`ServerReportService` (renamed from `MediaReportService`)
Also ensures a consistent header is used including the build flavor.
### Related issues
N/A
### Testing
Emulator
## Screenshots
N/A
## AI or LLM usage
None
## Description
Add scrolling from top to bottom and vice versa. This makes it quicker
to get to Advanced Settings for example.
### Related issues
N/A
### Testing
Emulator
## Screenshots
N/A
## AI or LLM usage
None
## Description
Added localized formatting for season/episode numbers across the UI
because it was in English-only in every UI language.
### Related issues
None
### Testing
Tested on a physical Google TV Streamer 4K device. Checked manually
relevant screens while browsing and during playback.
## Screenshots
No frontend changes are visible in English and new translations will be
contributed through Weblate for other languages later, as usual.
## AI or LLM usage
Generated initial code with AI, then manually passed over it while
cleaning and refactoring where needed.
---------
Co-authored-by: Damontecres <damontecres@gmail.com>
## Description
Fixes several issues on the Now Playing page
- Keep controller focus after lyrics are focused
- Fix the queue not visually updating until recomposition
- The first focused queue shown/focused is now what's currently playing
### Related issues
Fixes#1821
### Testing
Emulator
## Screenshots
N/A, just behavior fixes
## AI or LLM usage
None
## Description
This PR fixes how cards are displayed initially when creating the
default home page or loading it from the web config:
- Ensure view options are selected based on the library type (this is
how it's done already when manually adding a row)
- Support more home row types such as photos and music
### Related issues
Fixes https://github.com/damontecres/Wholphin/issues/1838
### Testing
Emulator, resetting to default and loading from web config
## Screenshots
N/A, music cards will be square instead of poster sized
## AI or LLM usage
None
## Description
Adds a random button on library tab/grid pages which navigates to a
random item in the list. This goes to the item's detail page.
The random item is chosen with the filters applied. So you could filter
by unplayed Action movies with 7+ stars and the random button will
select from those movies.
Pressing back restores focus on the random button so it's easy to
quickly retry.
### Related issues
Closes#838
### Testing
Emulator
## Screenshots
<img width="935" height="105" alt="image"
src="https://github.com/user-attachments/assets/170b495c-b47d-41ce-93b5-99831f2064c7"
/>
<img width="936" height="114" alt="image"
src="https://github.com/user-attachments/assets/3efa6a11-ebe8-42d7-b023-354b1e6eda37"
/>
## AI or LLM usage
None
## Description
Updates the compile & target SDKs to 37 (Android 17).
The only required change is to support the new `ACCESS_LOCAL_NETWORK`
permission. This is required for Android 17 devices to auto discover
Jellyfin servers on the local network. Wholphin will prompt for
permission and if granted, use the discover servers feature. If
permission is not granted, the user must enter the server URL manually.
### Related issues
N/A, but several dependency renovate PRs are blocked by this
### Testing
I tested with a regular Android 17 emulator. There are no Android TV 17
images (or probably even devices) available yet.
## Screenshots
N/A
## AI or LLM usage
None
## Description
This PR override Coil's built-in network connectivity checker with one
that allows returns true. The built-in one seems to be unreliable on
devices running Fire OS 6 (maybe other versions too) and/or devices
using a VPN such as Tailscale.
See more details here:
https://github.com/damontecres/Wholphin/issues/1800#issuecomment-5432941761
### Related issues
Should fix#1156
Should fix#1751
Should fix#1800
### Testing
Unfortunately, I've never been able to reproduce the original issue on
any of my devices, but hopefully someone who is affected can try this
branch out!
This change doesn't break anything on some emulators (tried Android 7.0
& Android TV 14) or NVIDIA shield
## Screenshots
N/A
## AI or LLM usage
None
## Try it
See instructions here:
https://github.com/damontecres/Wholphin/releases/tag/develop-image-fix
## Description
This PR adds many more data types as tabs to the favorites page.
Additionally, only tabs for the types the user has favorites for will
appear. For example, if you have no favorited music videos, that tab
will not show.
Added types:
- Collections
- TV Channels
- Music albums
- Music artists
- Music videos
- Songs
- Home videos
- Photos
- Photo albums
Dev note: The tabs are implemented using keys instead of indexes which
could be useful for the series overview season tabs. Plus it maybe even
be adapted for the episode list to eliminate the terrible index search
logic. A major difference is that the possible favorites tabs are
known/static list where seasons/episodes are queried & paginated.
### Related issues
Closes#1041Closes#1844
### Testing
Manually on emulator, plus unit tests
## Screenshots
N/A
## AI or LLM usage
None
## Description
This fixes the brief full screen white flash when the app starts or
reloads.
I bisected to find the cause which was #1653. The newly added `Surface`
uses `MaterialTheme` to set its colors. `MaterialTheme` defaults to a
generic _light_ color scheme. So this PR applies the Wholphin's default
purple theme, which will then be overridden once the app preferences are
loaded.
### Related issues
Mentioned in
https://github.com/damontecres/Wholphin/issues/1576#issuecomment-5376373039
### Testing
Used emulator with "Don't keep activities" and repeatedly opened &
closed the app to see if the white flash visually occurred
## Screenshots
N/A
## AI or LLM usage
None
## Description
This PR adds several more data types to search. It also adds a setting
(per use profile) to choose which types to include/exclude when
searching. The combined results now uses the same types instead of a
separate list.
A user can only search for types that they have access to. For example,
they need Live TV access for TV channels/programs or need access to a
movies-type library to search movies.
Added types to search:
- Photos & Photo albums
- Playlists
- People
- TV channels
- Live TV programs
Clicking a TV channel will play it. Clicking a TV program shows the
program dialog allowing for recording or watching live if it's currently
airing.
On the main search page you can also toggle whether to search Seerr or
not. This does not apply to the discover search tab.
Dev note: Some minor refactoring to move setting up/canceling live tv
recordings into a new service so it can be shared between with the live
tv & search pages. Also search related files are moved into the same
package now.
### Related issues
Closes#409Closes#646Closes#1668Closes#1750
### Testing
Emulator using users with different permissions and library access
## Screenshots
<img width="475" height="584" alt="image"
src="https://github.com/user-attachments/assets/ebcff697-07ba-4ddd-8c26-57f147cfa02a"
/>
## AI or LLM usage
None
## Description
When parsing intents, not every path for authentication was checked, so
launching via the "Next Up" OS channel wouldn't check for a profile PIN.
This PR fixes that.
Additionally, the "Next Up" OS channel launch wasn't checking the
correct parameter to ensure the back stack was written properly.
### Related issues
Fixes#1883
### Testing
I manually test on the emulator with these test cases:
- No profile PIN, cold start
- No profile PIN, hot start
- Profile PIN, cold start
- Profile PIN, hot start
- No profile PIN, launch via "Next Up" channel
- No profile PIN, launch via intent
- Profile PIN, launch via "Next Up" channel
- Profile PIN, launch via intent
Also added unit tests for intent-based and regular launching which
covers those cases and more.
## Screenshots
N/A
## AI or LLM usage
None
## Description
Another PR to gather small bug fixes:
- Fix aspect ratio for episodes on person page
- Use the song's artist instead of the album's artist on album page
- Fix how the dim percentage is applied to the OS screensaver dim
percentage (#1834)
### Related issues
Fixes#1851Fixes#1863
### Testing
<!-- Describe how this change was tested and on what device(s) -->
## Screenshots
<!-- Please include screenshots if the PR alters any UI elements -->
## AI or LLM usage
<!-- If you used any AI or LLM assistance, please list where in the code
and how you tested it -->
## Description
There were two problems with the experimental "Use AC3 for surround
sound audio" setting (#947):
1. Defaulted to true
2. Access wasn't guarded by enabling experimental settings
This caused unintentional audio transcoding
### Related issues
Fixes#1878
### Testing
Emulator
## Screenshots
N/A
## AI or LLM usage
None
## Description
Slight optimization to remove "child count" for grid pages. Adds back
"primary image aspect ratio" for several queries where its necessary.
Also updates extras cards to use the "primary image aspect ratio"
instead of a hard coded value.
Dev note: some light refactoring is also in this PR including renaming
the item fields lists to better reflect the intended usage in code
### Related issues
Fixes#1843
### Testing
Emulator, I tested many pages and views, but probably need to do "real
world" testing to see if I missed anything
## Screenshots
N/A
## AI or LLM usage
None
## Description
Adds a new sceensaver setting to add dimming. A larger value is darker
This works with or without the in-app screensaver. If dimming is
enabled, the screen be will be dimmed after inactivity. If both dimming
and the in-app screensaver are enabled, the screensaver will show dimmed
after inactivity.
### Related issues
Closes#1179
### Testing
Emulator
## Screenshots
N/A, it's just darker
## AI or LLM usage
None
## Description
The audio player passed handleAudioFocus = false when setting its audio
attributes, so ExoPlayer never requested audio focus. Music kept playing
and mixed with other audio when a call arrived, another app started
playback, or voice search took focus.
### Related issues
Fixes https://github.com/damontecres/Wholphin/issues/1841
### Testing
1. Play a music track
2. Open YouTube and play a video
## AI or LLM usage
Cursor and Claude Code
## Description
Fixes several issues on the discover pages:
- Fixes sorting by release date for tv shows
- Fixes automatic go-to for movie & tv show grid
- Fixes tv show discover page's go-to using a movie detail page
- Updates the alignment & padding for the headers on different discover
pages to match the reset of the app
- Use media's logo image if available and the setting is enabled
### Related issues
N/A
### Testing
Emulator mostly
## Screenshots
N/A, headers and logos are unchanged, just moved slightly to match
regular content
## AI or LLM usage
None
## Description
When viewing images in a slideshow, this PR enqueues the next image so
it will likely be cached and ready to display when the slideshow
advances.
This works for both automatic and manual scrolling as well as advancing
next or previous images.
### Related issues
Closes#1835
### Testing
Emulator with large photos
## Screenshots
N/A
## AI or LLM usage
None
