Round 2 release candidate 3: polish lanes A-E, season reel and trailer return #82
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fm/tv-round2-candidate3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Trailer-return decision: correction pending
With Sign in automatically off, ordinary warm returns must show the profile picker. Only the first valid trailer handoff return may retain the same unprotected person/title (same boot, strictly under ten minutes); a second ordinary return shows the picker again. Automatic sign-in on and protected/cold-launch gates stay unchanged.
The correction is ready for review at #83, targeting
fm/tv-round2-candidate3. This candidate branch has not been updated: its exact head and existing build evidence below still refer to the original candidate. Do not treat this candidate as carrying the narrowed rule until that correction is accepted. The original trailer-return branch at #81 now contains the same correction at98db417ca29ddb1b8684007abc11d98007958670. Scoped verification passed 85 tests on the candidate correction and 77 on the original trailer branch, with zero failures/errors/skips in both runs. No release or TV installation is authorized by these changes.Round 2 release candidate 3: the seven open polish and bug-fix PRs merged together on top of
fm/tv-round2(12a81ca8), plus two candidate-only test-infra/test-side commits. Exact commit:3a315eb809e8fe0cb928b36f574006295b3fedb6. Nothing here has been merged intofm/tv-round2yet.PRs contained, merged in this order
fa08235ac4d4a986aae18882c714306080fbc62d(first merged at6f54bae3, then re-merged at this head)2572da00fde67194019308e137d4f75bb3e3f65f9a0ce25a27e84859b7e62ade10bf7f8bf042bc5df05b0de156fe5be05f6f8c5b6a5285d61c904fd0bfa9fbc941c43336b7eaa8959a7b9ea88af23980d418a89a2535778ee6353a2125073131d164a8781bdae30e11cff6195f8d4379333d45eb2bd10eeeThe library-up bug is not included (no fix exists). The lane heads carried no commit statuses at merge time.
Candidate-only commits (must be carried into
fm/tv-round2when this merges)3da8a31c): test-only constructor-call fixes caused by merging the lanes together (NavigationCutTest,TitleEntryBackTest,TitlePolishTest; plus resolving two test-file conflicts inPersonSwitchThreadingTestandTitlePlaybackNavigationTest, keeping both sides' constructor changes). Product code unchanged.Give the app test JVM a 2g heap(da003d9e):maxHeapSize = "2g"on the app test task inapp/build.gradle.kts. Test-infra only. Without it the first full run died with an OutOfMemoryError in the Robolectric test worker after 671 tests (the 512 MB Gradle default). This commit is a candidate-only addition that must be carried intofm/tv-round2when the candidate merges.Test evidence (read this carefully)
docker/gradle.sh debug --continue testDefaultDebugUnitTest: design 295/295 pass; app suite with the 2g heap: 946 tests, 945 pass, 1 failed. That result is fromda003d9e(merge plus the two commits above). The 1 failure wasUpdatesKeysTest.classicRequiresEveryRetainedRowAndTheRealScroller(expected first visible Settings index 4, was 3), which failed on polish lane E's earlier head6f54bae3alone: lane E replaced the Settings scroll tween withanimateFrameScroll, and main'sUpdatesKeysTeststill waited a fixed 320 ms.fa08235a: the test waits for scroll idle, assertion at index 4 unchanged). This candidate head3a315eb8differs fromda003d9eonly by that lane E commit. Verified by a targeted run, not a second full run:UpdatesKeysTest6/6 andScrollMomentumTest6/6 pass on3a315eb8.NavigationCutTest.reducedMotionKeepsOpaqueCutsAndRetiresOutgoingByFourFrames, which passes in the rerun (and alone); no skipped test appears in the rerun (0 skipped).Opt build (this commit)
bash docker/gradle.sh optimized --offline -PtvVersion=1.1.1 -PtvVersionCode=70 ... :app:assembleDefaultOptimized, all four APKs in one run: packageorg.justinvisser.wolfskin.tv.opt, labelWolfskin (Opt), not debuggable, versionCode 70, versionName1.1.1, signer SHA-256182bac72e292b9ea4d3d4e6383f92eb2161fa28ba5afcff0337cb7d5a9d5341d(matches), baseline.prof/.profm present, no fixture assets, nomissing_rules.txt. A debug build of the same commit was made for the emulator walk.