justinzeus/wolfskin
1
0
Fork 0
Code Issues 2 Pull requests 1 Releases 3 Packages Activity

Change application id to org.justinvisser.wolfskin.tv #18

Merged
justinzeus merged 1 commit from fm/wolfskin-3-package-id into main 2026-10-22 15:58:32 +02:00
Conversation 0 Commits 1 Files changed 2 +10 -10
justinzeus commented 2026-10-22 15:57:28 +02:00
Owner
Copy link

Closes justinzeus/wolfskin#3

Changes the Android application id from com.github.damontecres.wholphin to org.justinvisser.wolfskin.tv so Wolfskin TV installs beside upstream Wholphin. Debug keeps the .debug suffix (org.justinvisser.wolfskin.tv.debug). Kotlin package, namespace, and upstream .github/workflows are unchanged.

Changes

  • app/build.gradle.kts:75: applicationId set to org.justinvisser.wolfskin.tv. No other Gradle edits.
  • Intents.md: the adb shell am start -n examples now use org.justinvisser.wolfskin.tv/com.github.damontecres.wholphin.MainActivity. The package prefix of -n is the application id, so these examples would fail against the new install otherwise. The component class path stays because the Kotlin package stays.

Hard-coded com.github.damontecres.wholphin hits (audit)

  • app/build.gradle.kts:71 namespace: keep (Kotlin package / R class, not the application id).
  • app/build.gradle.kts:80 testInstrumentationRunner class: keep (Kotlin package of test runner).
  • app/build.gradle.kts:268-272 seerr codegen package names: keep (generated Kotlin packages).
  • app/src/main/AndroidManifest.xml:65 action com.github.damontecres.wholphin.PLAYBACK: keep. It is an intent action string, not an application id or provider authority.
  • app/src/main/proto/WholphinDataStore.proto java_package, app/proguard-rules.pro, gradle/libs.versions.toml extension coordinates, wholphin-mpv-stub namespace/packages: keep (Kotlin or Maven coordinates).
  • README.md, DEVELOPMENT.md, renovate.json: keep (upstream Play store link and Maven patterns, not runtime ids).
  • Test sources under app/src/test and app/src/androidTest: no application-id uses found.
  • No context.packageName comparisons or provider authorities use the old id.

Verification (final head 06c783a4)

  • flock /tmp/wolfskin-gradle.lock make apk-debug: exit 0, BUILD SUCCESSFUL in 3m 8s.
  • flock /tmp/wolfskin-gradle.lock make test: exit 0, BUILD SUCCESSFUL in 1m 58s.
  • aapt2 dump badging on app/build/outputs/apk/default/debug/Wholphin-default-debug-1.0.9-6-g06c783a4-53.apk (build-tools 36.0.0, inside wolfskin-build:sdk37-jdk21): package: name='org.justinvisser.wolfskin.tv.debug'.

Not run: make apk (release signing), per the spec.

Closes justinzeus/wolfskin#3 Changes the Android application id from `com.github.damontecres.wholphin` to `org.justinvisser.wolfskin.tv` so Wolfskin TV installs beside upstream Wholphin. Debug keeps the `.debug` suffix (`org.justinvisser.wolfskin.tv.debug`). Kotlin package, `namespace`, and upstream `.github/workflows` are unchanged. ## Changes - `app/build.gradle.kts:75`: `applicationId` set to `org.justinvisser.wolfskin.tv`. No other Gradle edits. - `Intents.md`: the `adb shell am start -n` examples now use `org.justinvisser.wolfskin.tv/com.github.damontecres.wholphin.MainActivity`. The package prefix of `-n` is the application id, so these examples would fail against the new install otherwise. The component class path stays because the Kotlin package stays. ## Hard-coded `com.github.damontecres.wholphin` hits (audit) - `app/build.gradle.kts:71` `namespace`: keep (Kotlin package / R class, not the application id). - `app/build.gradle.kts:80` `testInstrumentationRunner` class: keep (Kotlin package of test runner). - `app/build.gradle.kts:268-272` seerr codegen package names: keep (generated Kotlin packages). - `app/src/main/AndroidManifest.xml:65` action `com.github.damontecres.wholphin.PLAYBACK`: keep. It is an intent action string, not an application id or provider authority. - `app/src/main/proto/WholphinDataStore.proto` `java_package`, `app/proguard-rules.pro`, `gradle/libs.versions.toml` extension coordinates, `wholphin-mpv-stub` namespace/packages: keep (Kotlin or Maven coordinates). - `README.md`, `DEVELOPMENT.md`, `renovate.json`: keep (upstream Play store link and Maven patterns, not runtime ids). - Test sources under `app/src/test` and `app/src/androidTest`: no application-id uses found. - No `context.packageName` comparisons or provider authorities use the old id. ## Verification (final head `06c783a4`) - `flock /tmp/wolfskin-gradle.lock make apk-debug`: exit 0, `BUILD SUCCESSFUL in 3m 8s`. - `flock /tmp/wolfskin-gradle.lock make test`: exit 0, `BUILD SUCCESSFUL in 1m 58s`. - `aapt2 dump badging` on `app/build/outputs/apk/default/debug/Wholphin-default-debug-1.0.9-6-g06c783a4-53.apk` (build-tools 36.0.0, inside `wolfskin-build:sdk37-jdk21`): `package: name='org.justinvisser.wolfskin.tv.debug'`. Not run: `make apk` (release signing), per the spec.
justinzeus added 1 commit 2026-10-22 15:57:28 +02:00
Change application id to org.justinvisser.wolfskin.tv
All checks were successful
review/firstmate Exact-diff check: only applicationId line + Intents.md adb examples; aapt2 badging proof org.justinvisser.wolfskin.tv.debug; apk-debug+test green
06c783a44a
justinzeus merged commit 4ae2171061 into main 2026-10-22 15:58:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
exploring

Idea with a proof gate; not scheduled until the gate passes

No labels
exploring
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: justinzeus/wolfskin#18
No description provided.
Delete branch "fm/wolfskin-3-package-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?